Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): eslint-recommended: disable no-func-assign #984

Merged
merged 2 commits into from May 9, 2020

Conversation

OliverSieweke
Copy link
Contributor

@OliverSieweke OliverSieweke commented Sep 17, 2019

BREAKING CHANGE:

Fixes #983

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @OliverSieweke!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added breaking change This change will require a new major version to be released recommended-rules Discussion about recommended rule sets labels Sep 18, 2019
@bradzacher bradzacher changed the title fix(eslint-plugin): [no-func-assign] disable rule handled by TS (#983) chore(eslint-plugin): eslint-recommended: disable no-func-assign (#983) Sep 18, 2019
@bradzacher bradzacher added this to the 3.0.0 milestone Sep 23, 2019
@bradzacher bradzacher changed the base branch from master to v3 May 9, 2020 21:32
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #984 into v3 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v3     #984   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         171      171           
  Lines        7789     7789           
  Branches     2240     2240           
=======================================
  Hits         7315     7315           
  Misses        217      217           
  Partials      257      257           
Flag Coverage Δ
#unittest 93.91% <ø> (ø)
Impacted Files Coverage Δ
...es/eslint-plugin/src/configs/eslint-recommended.ts 100.00% <ø> (ø)

@bradzacher bradzacher changed the title chore(eslint-plugin): eslint-recommended: disable no-func-assign (#983) feat(eslint-plugin): eslint-recommended: disable no-func-assign May 9, 2020
@bradzacher bradzacher merged commit d793458 into typescript-eslint:v3 May 9, 2020
bradzacher pushed a commit that referenced this pull request May 11, 2020
bradzacher pushed a commit that referenced this pull request May 14, 2020
bradzacher pushed a commit that referenced this pull request May 17, 2020
bradzacher pushed a commit that referenced this pull request May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released recommended-rules Discussion about recommended rule sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-func-assign] Duplicates TypeScript's TS2539 error
2 participants