From 8df30ae5134dd95b40d3677835455f46015c4168 Mon Sep 17 00:00:00 2001 From: JayaKrishna Date: Fri, 19 Jul 2019 13:49:13 +0530 Subject: [PATCH 1/2] =?UTF-8?q?fix:=20=F0=9F=90=9B=20Throwig=20error=20if?= =?UTF-8?q?=20parent=20is=20CallExpression?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Throwing error if the parent is CallExpression in no-var-requires plugin Closes: #665 --- packages/eslint-plugin/src/rules/no-var-requires.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/no-var-requires.ts b/packages/eslint-plugin/src/rules/no-var-requires.ts index 8d8e714c4f5..29b1c77dd34 100644 --- a/packages/eslint-plugin/src/rules/no-var-requires.ts +++ b/packages/eslint-plugin/src/rules/no-var-requires.ts @@ -27,7 +27,8 @@ export default util.createRule({ node.callee.type === AST_NODE_TYPES.Identifier && node.callee.name === 'require' && node.parent && - node.parent.type === AST_NODE_TYPES.VariableDeclarator + (node.parent.type === AST_NODE_TYPES.VariableDeclarator || + node.parent.type === AST_NODE_TYPES.CallExpression) ) { context.report({ node, From e2ad8aceb433df638622e9c2a955eb24c6490b1f Mon Sep 17 00:00:00 2001 From: JayaKrishna Date: Wed, 24 Jul 2019 11:38:34 +0530 Subject: [PATCH 2/2] =?UTF-8?q?test:=20=F0=9F=92=8D=20Added=20test=20case?= =?UTF-8?q?=20for=20checking=20no-var-require?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adding a missing test case after handling new edge case Closes: #665 --- .../eslint-plugin/tests/rules/no-var-requires.test.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts index f209c2069f0..b042ac1f806 100644 --- a/packages/eslint-plugin/tests/rules/no-var-requires.test.ts +++ b/packages/eslint-plugin/tests/rules/no-var-requires.test.ts @@ -38,5 +38,15 @@ ruleTester.run('no-var-requires', rule, { }, ], }, + { + code: "let foo = trick(require('foo'))", + errors: [ + { + messageId: 'noVarReqs', + line: 1, + column: 17, + }, + ], + }, ], });