fix: IsNumberString accept isNumbericOptions as argument

BREAKING CHANGE: IsNumberString decorator arguments changed to @IsNumberString(ValidatorJS.IsNumericOptions, ValidationOptions). Closes #518, #463
typestack · Mar 26, 2020 · 62b993f · 62b993f
1 parent 4eb1216
commit 62b993f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/decorator/decorators.ts b/src/decorator/decorators.ts
@@ -548,13 +548,13 @@ export function IsBooleanString(validationOptions?: ValidationOptions): Property
 /**
  * Checks if the string is a number.
  */
-export function IsNumberString(validationOptions?: ValidationOptions, NumberOptions?: IsNumberOptions): PropertyDecorator {
+export function IsNumberString(options?: ValidatorJS.IsNumericOptions, validationOptions?: ValidationOptions): PropertyDecorator {
     return function (object: Object, propertyName: string) {
         const args: ValidationMetadataArgs = {
             type: ValidationTypes.IS_NUMBER_STRING,
             target: object.constructor,
             propertyName: propertyName,
-            constraints: [NumberOptions],
+            constraints: [options],
             validationOptions: validationOptions
         };
         getMetadataStorage().addValidationMetadata(new ValidationMetadata(args));

diff --git a/src/validation/Validator.ts b/src/validation/Validator.ts
@@ -182,7 +182,7 @@ export class Validator {
             case ValidationTypes.IS_BOOLEAN_STRING:
                 return this.isBooleanString(value);
             case ValidationTypes.IS_NUMBER_STRING:
-                return this.isNumberString(value);
+                return this.isNumberString(value, metadata.constraints[0]);
 
             /* string checkers */
             case ValidationTypes.CONTAINS: