From 62b993f3d360c8844687c8856ae9d84bb50b8654 Mon Sep 17 00:00:00 2001 From: vlapo Date: Thu, 26 Mar 2020 20:48:27 +0100 Subject: [PATCH] fix: IsNumberString accept isNumbericOptions as argument BREAKING CHANGE: IsNumberString decorator arguments changed to @IsNumberString(ValidatorJS.IsNumericOptions, ValidationOptions). Closes #518, #463 --- src/decorator/decorators.ts | 4 ++-- src/validation/Validator.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/decorator/decorators.ts b/src/decorator/decorators.ts index 510bb2dd3..bcafe8d7e 100644 --- a/src/decorator/decorators.ts +++ b/src/decorator/decorators.ts @@ -548,13 +548,13 @@ export function IsBooleanString(validationOptions?: ValidationOptions): Property /** * Checks if the string is a number. */ -export function IsNumberString(validationOptions?: ValidationOptions, NumberOptions?: IsNumberOptions): PropertyDecorator { +export function IsNumberString(options?: ValidatorJS.IsNumericOptions, validationOptions?: ValidationOptions): PropertyDecorator { return function (object: Object, propertyName: string) { const args: ValidationMetadataArgs = { type: ValidationTypes.IS_NUMBER_STRING, target: object.constructor, propertyName: propertyName, - constraints: [NumberOptions], + constraints: [options], validationOptions: validationOptions }; getMetadataStorage().addValidationMetadata(new ValidationMetadata(args)); diff --git a/src/validation/Validator.ts b/src/validation/Validator.ts index 4e6945fd4..bb6117f59 100644 --- a/src/validation/Validator.ts +++ b/src/validation/Validator.ts @@ -182,7 +182,7 @@ export class Validator { case ValidationTypes.IS_BOOLEAN_STRING: return this.isBooleanString(value); case ValidationTypes.IS_NUMBER_STRING: - return this.isNumberString(value); + return this.isNumberString(value, metadata.constraints[0]); /* string checkers */ case ValidationTypes.CONTAINS: