Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: libphonenumber.js is loaded without using the IsMobilePhone decorator #247

Closed
websolutions-hamburg opened this issue Aug 7, 2018 · 2 comments · Fixed by #568
Closed

fix: libphonenumber.js is loaded without using the IsMobilePhone decorator #247

websolutions-hamburg opened this issue Aug 7, 2018 · 2 comments · Fixed by #568
Labels
priority: high type: fix Issues describing a broken feature.

Comments

@websolutions-hamburg
Copy link

websolutions-hamburg commented Aug 7, 2018 •
edited

The huge library libphonenumber.js is loaded, although I did not use the IsMobilePhone decorator.

Is it possible to load this library only if we use the decorator?
@HonoluluHenk HonoluluHenk mentioned this issue Sep 13, 2018
Closed
@NoNameProvided
Copy link
Member

Not in the current version but @HonoluluHenk has started to work in this in #258. When that is merged, this problem will be solved.

@NoNameProvided NoNameProvided added type: fix Issues describing a broken feature. priority: high labels Nov 4, 2018
@vlapo vlapo mentioned this issue Mar 30, 2020
Merged
vlapo added a commit that referenced this issue Apr 17, 2020
@vlapo
refactor: update build process to enable tree shaking (#568)
11a7b8b 
BREAKING CHANGE: 

Validation functions was removed from `Validator` class to enable tree shaking.

BEFORE:

    import {Validator} from "class-validator";

    const validator = new Validator();
    validator.isNotIn(value, possibleValues);
    validator.isBoolean(value);

AFTER:

    import {isNotIn, isBoolean} from "class-validator";

    isNotIn(value, possibleValues);
    isBoolean(value);

Closes #258, #248, #247, #212
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@NoNameProvided NoNameProvided changed the title libphonenumber.js is loaded without using the IsMobilePhone decorator fix: libphonenumber.js is loaded without using the IsMobilePhone decorator Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: high type: fix Issues describing a broken feature.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update build process to enable tree shaking
2 participants
@NoNameProvided @websolutions-hamburg