Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new isLocale validator #425

Closed
rubiin opened this issue Sep 26, 2019 · 16 comments
Closed

feat: new isLocale validator #425

rubiin opened this issue Sep 26, 2019 · 16 comments
Labels
status: done/released Issue has been completed, no further action is needed. type: feature Issues related to new features.

Comments

@rubiin
Copy link
Contributor

rubiin commented Sep 26, 2019

I was working on a project that passed the language header to request the response in desired language. However I could not find it in the class-validator. How about making one. Can do a pr

@rubiin
Copy link
Contributor Author

rubiin commented Oct 1, 2019

@vlapo what do u say about this

@vlapo
Copy link
Contributor

vlapo commented Oct 1, 2019

I think we have one PR about extending error messages #238. But this is kind of advanced topic and I do not decide how to handle it, yet.

@rubiin
Copy link
Contributor Author

rubiin commented Oct 2, 2019

i mean do we have something to check whether a given string is a valid language like isLanguage or isLocale ? @vlapo

@rubiin
Copy link
Contributor Author

rubiin commented Oct 5, 2019

I checked validator.js but there is no such validator available perhaps we have to make a new one @vlapo

@vlapo
Copy link
Contributor

vlapo commented Oct 14, 2019

Looks like there is FR validatorjs/validator.js#954 and PR validatorjs/validator.js#1072. I would like to wait and use validatorjs function (if PR will be merged in some reasonable time).

@vlapo vlapo added status: blocked Issues being blocked by a different issue. type: feature Issues related to new features. labels Oct 14, 2019
@vlapo vlapo changed the title Feature to check language for localization? feat: new isLocale validator Oct 16, 2019
@arkus7
Copy link

arkus7 commented Feb 16, 2020

@vlapo @rubiin mentioned PR has been merged :)

validatorjs/validator.js#1072

@rubiin
Copy link
Contributor Author

rubiin commented Feb 16, 2020

@arkus7 thanks for the info. I will be doing a pr shortly

@johannesschobel
Copy link

merged but not released :D

@johannesschobel
Copy link

Dear @vlapo and @rubiin ,
theisLocale() function has now been released in validatorjs 13.0.0!

@rubiin
Copy link
Contributor Author

rubiin commented Mar 24, 2020 via email

@vlapo
Copy link
Contributor

vlapo commented Mar 24, 2020

@rubiin please also create new added validators (isEthereumAddress, isIBAN, ...)

@rubiin
Copy link
Contributor Author

rubiin commented Mar 25, 2020 via email

@vlapo vlapo removed the status: blocked Issues being blocked by a different issue. label Mar 27, 2020
@vlapo
Copy link
Contributor

vlapo commented Mar 29, 2020

@rubiin please wait with this changes. I have one big PR with lot of changes almost ready.

@rubiin
Copy link
Contributor Author

rubiin commented Mar 30, 2020

@vlapo sure

@vlapo
Copy link
Contributor

vlapo commented Apr 18, 2020

@rubiin I synced validatorjs lib to v13 (isLocale included). Thank you for help with provide this new validator.

@vlapo vlapo closed this as completed Apr 18, 2020
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@NoNameProvided NoNameProvided added the status: done/released Issue has been completed, no further action is needed. label Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: done/released Issue has been completed, no further action is needed. type: feature Issues related to new features.
Development

No branches or pull requests

5 participants