Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IsNumericOptions is missing no_symbols #463

Closed
shayded-exe opened this issue Nov 16, 2019 · 6 comments
Closed

fix: IsNumericOptions is missing no_symbols #463

shayded-exe opened this issue Nov 16, 2019 · 6 comments
Labels
status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature.

Comments

@shayded-exe
Copy link

As the title says. Validator.js accepts a no_symbols argument, but IsNumericOptions doesn't declare it.
@rubiin
Copy link
Contributor

rubiin commented Nov 20, 2019

thanks for the feedback, i have added this in the pr #467

@vlapo
Copy link
Contributor

vlapo commented Mar 24, 2020

@rubiin what is status of this one?

@rubiin
Copy link
Contributor

rubiin commented Mar 25, 2020

@vlapo i have submitted a pr already

@vlapo
Copy link
Contributor

vlapo commented Mar 25, 2020

PR is closed

@rubiin
Copy link
Contributor

rubiin commented Mar 25, 2020

looks like it was already resolved

@vlapo vlapo closed this as completed Mar 27, 2020
@lock
Copy link

lock bot commented Apr 4, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
@NoNameProvided NoNameProvided added status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature. labels Aug 8, 2020
@NoNameProvided NoNameProvided changed the title IsNumericOptions is missing no_symbols fix: IsNumericOptions is missing no_symbols Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shayded-exe @vlapo @NoNameProvided @rubiin