fix: optional constraints property in ValidationError

[ghost]

Motivation

I had this log method when an error was appearing :

function logErrors(fieldErrors: { requestField: string; error: ValidationError }[]): void {
    console.log(fieldErrors);
    const errorMessages = fieldErrors
        .map(({ requestField, error }) => `- ${requestField}: ${Object.values(error.constraints)}`)
        .join('\n\t');
    logger.error(new Error(`Bad request.\n\t${errorMessages}`));
}

This triggered a runtime error when error.constraints was undefined. This is the kind of error that could be avoided by Typescript check if the field was optional in ts declaration

Error reproduction

ValidationError.constraint can be undefined if there is only a nested validation error

Others tracks of resolution

Maybe instead of changing the declaration, it's better to make sure the field is never undefined. We can discuss about this and I will modify the PR

[vlapo]

I agree. Issue already exists #309. But this kind of change is a small breaking change. Will merge this to 0.12.0 release.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.