Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: excluding google-libphonenumber #472

Closed
binaryangel-noa opened this issue Nov 21, 2019 · 7 comments
Closed

question: excluding google-libphonenumber #472

binaryangel-noa opened this issue Nov 21, 2019 · 7 comments
Labels
status: duplicate Issue is being tracked already in another issue. type: question Questions about the usage of the library.

Comments

@binaryangel-noa
Copy link

Google libphonumber is a large depdendency of the class-valdiator package (450KB vs 50KB of class-valdiator). Is there an option to use it optionally ?
@rubiin
Copy link
Contributor

rubiin commented Nov 21, 2019

i dont think you can use it optionally or may be i am wrong, perhaps @vlapo can tell you more

@vlapo
Copy link
Contributor

vlapo commented Nov 26, 2019

Sorry there is such option.

@vlapo vlapo added the type: question Questions about the usage of the library. label Nov 26, 2019
@alex-nishikawa
Copy link

alex-nishikawa commented Dec 19, 2019 •
edited

Does this library support just using the modules you want? Example:

import length from 'class-validator/length

@vlapo
Copy link
Contributor

vlapo commented Jan 10, 2020

No this library do not support tree shaking and modules yet.

@AndrinGautschi
Copy link

AndrinGautschi commented Feb 20, 2020 •
edited

Is someone working on this issue?

Edit:
Found this #258

@vlapo
Copy link
Contributor

vlapo commented Mar 27, 2020

Duplicate of #248

@vlapo vlapo marked this as a duplicate of #248 Mar 27, 2020
@vlapo vlapo closed this as completed Mar 27, 2020
@lock
Copy link

lock bot commented Apr 4, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
@NoNameProvided NoNameProvided changed the title Excluding google-libphonenumber question: excluding google-libphonenumber Aug 8, 2020
@NoNameProvided NoNameProvided added the status: duplicate Issue is being tracked already in another issue. label Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: duplicate Issue is being tracked already in another issue. type: question Questions about the usage of the library.
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vlapo @alex-nishikawa @NoNameProvided @rubiin @AndrinGautschi @binaryangel-noa