Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorators for IsLatitude and IsLongitude have wrong types #502

Closed
scottcollins opened this issue Jan 5, 2020 · 5 comments
Closed

Decorators for IsLatitude and IsLongitude have wrong types #502

scottcollins opened this issue Jan 5, 2020 · 5 comments
Labels
type: fix Issues describing a broken feature.

Comments

@scottcollins
Copy link

The IsLatitude decorator defines a type of IS_LONGITUDE and the IsLongitude decorator defines a type of IS_LONGITUDE. Should be the other way around
@scottcollins
Copy link
Author

I have a pull request ready for this, but I do not have access to push to a branch. how can I get access?

@vlapo
Copy link
Contributor

vlapo commented Jan 13, 2020

You have to fork this repository, commit in forked one and create PR https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork.

@vlapo vlapo added the type: fix Issues describing a broken feature. label Jan 13, 2020
@vlapo
Copy link
Contributor

vlapo commented Mar 24, 2020

@rubiin could you please check this one? Check if it is real bug and create PR - looks like a simple fix.

@vlapo vlapo mentioned this issue Mar 25, 2020
Merged
@rubiin
Copy link
Contributor

rubiin commented Mar 25, 2020

@vlapo fixed in pr #563

@vlapo vlapo closed this as completed in 5497179 Mar 26, 2020
@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: fix Issues describing a broken feature.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlapo @rubiin @scottcollins