Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IsNumber validator now works when maxDecimalPlaces=0 #524

Merged
merged 1 commit into from Mar 18, 2020

Conversation

tmtron
Copy link
Contributor

@tmtron tmtron commented Feb 12, 2020

No description provided.

@vlapo
Copy link
Contributor

vlapo commented Mar 16, 2020

Please update your PR.

  • update only code related to this PR
  • do not update package.json
  • do not update indents

@tmtron
Copy link
Contributor Author

tmtron commented Mar 17, 2020

I've undone changes to package.json

I did not change the indentation - it seems my IDE automatically removes trailing whitespace (on save/commit) - I could not find a way to switch this off. You should conisder using prettier to get consistent formatting.

@vlapo vlapo changed the title fixed #523: IsNumber validator now works when maxDecimalPlaces=0 fix: IsNumber validator now works when maxDecimalPlaces=0 Mar 18, 2020
@vlapo vlapo merged commit b8aa922 into typestack:master Mar 18, 2020
@github-actions
Copy link

github-actions bot commented Aug 3, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants