Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @IsMobilePhone(locale: string) missing strict mode and documentation #576

Closed
carlocorradini opened this issue Apr 6, 2020 · 2 comments
Closed

fix: @IsMobilePhone(locale: string) missing strict mode and documentation #576

carlocorradini opened this issue Apr 6, 2020 · 2 comments
Labels
status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature.

Comments

@carlocorradini
Copy link
Contributor

Checking validatorjs documentation i can use @IsMobilePhone decorator with any as locale and strictMode enabled.
However in class-validator i can only set locale and none strictMode.
Moreover the documentation for this decorator is missing some part from validatorjs docs(any and strictMode):

validatorjs docs:

Untitled

class-validator docs:

Untitled

Is possible to fix this?
Thanks in advance
@vlapo
Copy link
Contributor

vlapo commented Apr 7, 2020

Sure. We can include this fix in 0.12.x. Hope in few weeks after #568 merge

@vlapo vlapo added the type: fix Issues describing a broken feature. label Apr 7, 2020
@vlapo vlapo closed this as completed in 09120b7 Apr 18, 2020
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
@NoNameProvided NoNameProvided added the status: done/released Issue has been completed, no further action is needed. label Aug 8, 2020
@NoNameProvided NoNameProvided changed the title @IsMobilePhone(locale: string) missing strict mode and documentation fix: @IsMobilePhone(locale: string) missing strict mode and documentation Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: done/released Issue has been completed, no further action is needed. type: fix Issues describing a broken feature.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vlapo @NoNameProvided @carlocorradini