Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseBefor decorator execute in wrong order #794

Open
cojack opened this issue Oct 25, 2021 · 0 comments · May be fixed by #795
Open

UseBefor decorator execute in wrong order #794

cojack opened this issue Oct 25, 2021 · 0 comments · May be fixed by #795
Labels
flag: needs discussion Issues which needs discussion before implementation.

Comments

@cojack
Copy link

cojack commented Oct 25, 2021

As we can assume, @UseBefor should be executed BEFORE method invocation, but unfortunately is executed BEFORE any other middleware which makes no sense and prevents using it as a kind of Guard for specific endpoint.

As we can see here:

routing-controllers/src/driver/express/ExpressDriver.ts

Line 185 in cf1117d

...[route, routeGuard, ...beforeMiddlewares, ...defaultMiddlewares, routeHandler, ...afterMiddlewares]

@cojack cojack linked a pull request Oct 25, 2021 that will close this issue
Open
6 tasks
@attilaorosz attilaorosz added the flag: needs discussion Issues which needs discussion before implementation. label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag: needs discussion Issues which needs discussion before implementation.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(driver): Change order of middlewares execution cojack/routing-controllers
2 participants
@cojack @attilaorosz