Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fontWeight types #349

Open
satvikpendem opened this issue Dec 17, 2019 · 3 comments
Open

Add fontWeight types #349

satvikpendem opened this issue Dec 17, 2019 · 3 comments

Comments

@satvikpendem
Copy link

Looks like the only options available for fontWeight are those in this image. This means I can't set it to medium, light, semibold, or others, as well as not being able to specify these weights as between 100 and 900. Is there a way around this? I can add these types in a PR if needed, just let me know where to add them.

Also, I've noticed insufficient types for other CSS properties as well, I can help on working to fix them.

image

@TylorS
Copy link
Contributor

TylorS commented Dec 17, 2019

Hey @satvikpendem I think you could get around this by updating TypeStyle's csstype to the latest version as it definitely has number in the types for font-weight (https://raw.githubusercontent.com/frenic/csstype/master/index.d.ts, ctrl+f for 'FontWeightAbsolute').

And ideally we'd update the dependency directly in TypeStyle for these fixes.

@satvikpendem
Copy link
Author

Thanks, how would I update csstype, just yarn upgrade csstype?

@TylorS
Copy link
Contributor

TylorS commented Dec 19, 2019

I'm not 100% sure, but I think you do yarn csstype to add it to your dependencies. Your suggestion may work as well, I'm less familiar with yarn these days.

I'd try them both out and report back how you make out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants