Remove is-ci in favor of ci-info #579
Conversation
xenyal
force-pushed
the
remove_is_ci
branch
2 times, most recently
from
719ad39
to
44c778e
Compare
|
Thanks! |
src/installer/bin.ts
Outdated
| @@ -13,6 +13,9 @@ debug(`INIT_CWD: ${process.env.INIT_CWD}`) | |||
| // huskyDir is ONLY used in dev, don't use this arguments | |||
| const [, , action, huskyDir = path.join(__dirname, '../..')] = process.argv | |||
|
|
|||
| // Determine whether environment is CI | |||
| const { isCI } = ci.isCI | |||
There was a problem hiding this comment.
Except if I'm missing something, shouldn't it be const { isCI } = ci based on https://github.com/watson/ci-info#usage?
There was a problem hiding this comment.
Based on the library's usage documentation, ci is the encapsulating namespace of the library, and isCI is the method that actually shows whether or not the call was invoked in a CI environment or not (ref: https://github.com/watson/ci-info#ciisci). Not sure if that answers your question, I'll keep an 👀out for further comments! Also, sorry for the late response!
There was a problem hiding this comment.
| const { isCI } = ci.isCI | |
| const { isCI } = ci |
Looks correct to me based on the linked documentation.
There was a problem hiding this comment.
@typicode @fearphage Updated - thank you both for the replies! 😄
src/installer/bin.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import chalk from 'chalk' | |||
| import isCI from 'is-ci' | |||
| import ci from 'ci-info' | |||
There was a problem hiding this comment.
More of a preference really, but just pull this out during import? ¯\_(ツ)_/¯ (Sorry I missed this earlier).
| import ci from 'ci-info' | |
| import { isCI } from 'ci-info' |
|
Thanks @fearphage, @xenyal |
Instead of having is-ci call ci-info's ci.isCI, we might as well call ci.isCI within the installation directly. This allows us to shorten the dependency branch by 1 step which is a trivial amount of gain, but it nonetheless reduces the length of the package-lock