Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cnpm fails due to $packgeManager not matched #687

Merged
merged 2 commits into from Apr 9, 2020

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Mar 10, 2020

close #682
close #676
close cnpm/cnpm#318

Reproduce steps

npm i cnpm -g
git clone git@github.com:afc163/husky-test.git
cd husky-test
cnpm i
touch README && git add README
git commit -am 'commit message'

husky pre-commit is not running.

Reason

$packageManager of husky defined didn't contain cnpm, which is using https://github.com/cnpm/npminstall, the $packageManager value should be npminstall.

Solution

It can be fallback to npx when $packageManager is npminstall.

Additionally, fixed Unknown package manager logic according to #682 in which @MondoGao had described.

@afc163
Copy link
Contributor Author

afc163 commented Mar 10, 2020

@afc163 afc163 changed the title fix: cnpm fail cause packgeManager not matched fix: cnpm fails due to $packgeManager not matched Mar 10, 2020
@afc163
Copy link
Contributor Author

afc163 commented Mar 16, 2020

Could anyone see this?

@afc163
Copy link
Contributor Author

afc163 commented Mar 25, 2020

@typicode Any chance to merge this?

@fengmk2
Copy link

fengmk2 commented Apr 9, 2020

+1, anyone can review then merge it?

@typicode
Copy link
Owner

typicode commented Apr 9, 2020

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants