Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maybe] Do not use the ugly regex, i.e: abandon this package #101

Open
tangrufus opened this issue Jan 30, 2020 · 1 comment
Open

[Maybe] Do not use the ugly regex, i.e: abandon this package #101

tangrufus opened this issue Jan 30, 2020 · 1 comment

Comments

@tangrufus
Copy link
Member

Modify https://github.com/Roave/FunctionFQNReplacer to perform search and replace.

Main difference: https://github.com/Roave/FunctionFQNReplacer/blob/master/src/NodeVisitor/ReplaceUnqualifiedFunctionCallsWithQualifiedReferences.php#L123-L137
@tangrufus tangrufus mentioned this issue Feb 6, 2020
Open
This was referenced Apr 14, 2020
Closed
Closed
@tangrufus tangrufus changed the title [maybe] Use Roave/FunctionFQNReplacer instead of ugly regex [Maybe] Do not use the ugly regex, i.e: abandon this package Apr 15, 2020
@tangrufus
Copy link
Member Author

Or, make a composer plugin for https://github.com/humbug/php-scoper

Multiple users moved away from imposter to php-scoper.
See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tangrufus