Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dayjs dependency #105

Open
amrdraz opened this issue Oct 18, 2019 · 2 comments
Open

remove dayjs dependency #105

amrdraz opened this issue Oct 18, 2019 · 2 comments

Comments

@amrdraz
Copy link

amrdraz commented Oct 18, 2019

this would be a very useful package if it didn't force my project to install and include dayjs in my bundle

would appreciate if you remove the dependency I think I fork and and remove the date hook and reference this repo

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@u3u
Copy link
Owner

u3u commented Nov 2, 2019

Thanks for the suggestion, date hook are not commonly used.
I will consider removing it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants