Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fail due to duplication with dayjs #205

Open
Goldziher opened this issue Mar 9, 2020 · 2 comments
Open

build fail due to duplication with dayjs #205

Goldziher opened this issue Mar 9, 2020 · 2 comments

Comments

@Goldziher
Copy link

Hi there. First thanks for this nice package. We are using it for the vuex bindings only though, and the added stuff is creating some problems:

ERROR in /var/www/yoda/node_modules/@u3u/vue-hooks/node_modules/dayjs/locale/index.d.ts(10,12):

10:12 Duplicate identifier 'locale'.

     8 |   const locale: locale.Locale

     9 | 

  > 10 |   export = locale

       |            ^

    11 | }

    12 | 



 error  in /var/www/yoda/node_modules/dayjs/locale/index.d.ts



ERROR in /var/www/yoda/node_modules/dayjs/locale/index.d.ts(10,12):

10:12 Duplicate identifier 'locale'.

     8 |   const locale: locale.Locale

     9 | 

  > 10 |   export = locale

       |            ^

    11 | }

    12 | 

I'd suggest moving dayjs into a peer dependency, or completely removing this hook from the package - after all, users might use a different library or a native implementation etc.

@leiyunkang7
Copy link

mark,我们项目也遇到这问题了

@Ruslancic
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants