Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception or stop the listener when SSL used but compiled without WITH_OPENSSL=1 #1459

Open
dr-blade opened this issue Jun 1, 2022 · 3 comments

Comments

@dr-blade
Copy link

dr-blade commented Jun 1, 2022

There also seems to be no warnings/errors if uWS is compiled without "WITH_OPENSSL=1" . It compiles and executes without using an ssl context even when the code tells it to.

Originally posted by @yuumikazoomi in #1132 (comment)

@dr-blade dr-blade changed the title Throw exception or stop the listen when SSL used but compiled without WITH_OPENSSL=1 Throw exception or stop the listener when SSL used but compiled without WITH_OPENSSL=1 Jun 1, 2022
@ghost
Copy link

ghost commented Jun 1, 2022

It's kind of a core feature that TLS and TCP have the same interface, so your app doesn't have to be rewritten when moving to TLS. uWebSockets doesn't know whether or not uSockets is compiled with SSL or not.

uSockets just default to TCP if not compiled with SSL

@ghost
Copy link

ghost commented Jun 1, 2022

You could make it so that uSockets fails of requested to do SSL without supporting it

@dr-blade dr-blade closed this as completed Jun 1, 2022
@uNetworkingAB uNetworkingAB reopened this Oct 8, 2022
@uNetworkingAB
Copy link
Contributor

int us_protocol_support (int)

Could be checked in listen and just print a different message as a hint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants