Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child scope of container is not visualized on dot graph #402

Open
greeflas opened this issue Jan 14, 2024 · 3 comments
Open

Child scope of container is not visualized on dot graph #402

greeflas opened this issue Jan 14, 2024 · 3 comments
Assignees

Comments

@greeflas
Copy link
Contributor

Describe the bug
Child scope of container is not visualized on dot graph.

To Reproduce

  1. Create container:
    c := dig.New()
  2. Provide the container with constructor:
    c.Provide(NewFirstComponent)
  3. Create child scope:
    child := c.Scope("test_scope")
  4. Provide the child scope with constructor:
    child.Provide(NewSecondComponent)
  5. Visualize container:
    dig.Visualize(c, os.Stdout)

Expected behavior
I expect to see child scope along with NewSecondComponent but I only see NewFirstComponent.

Additional context
Dig version: v1.17.1
Go Playground: https://go.dev/play/p/lhYAIUlfsPr
DOT:

digraph {
	rankdir=RL;
	graph [compound=true];
	
		subgraph cluster_0 {
			label = "main";
			constructor_0 [shape=plaintext label="NewFirstComponent"];
			
			"*main.FirstComponent" [label=<*main.FirstComponent>];
			
		}
		
		
	
}

Graph image:
graphviz (1)

@sywhang
Copy link
Contributor

sywhang commented Jan 16, 2024

This is a valid feature request. I believe the DOT representation wasn't rewritten when we rewrote Dig's internal graph representation when we worked on the Scope feature.

@greeflas
Copy link
Contributor Author

@sywhang should we close this issue or you want to add here info about future improvement that was discussed in pull request?

@sywhang
Copy link
Contributor

sywhang commented Jan 18, 2024

I'll leave this open for now since we need some more visual improvements. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants