ignores: Don't use strings.Contains #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 6 6
Lines 334 334
=======================================
Hits 329 329
Misses 4 4
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
force-pushed
the
strings-contains
branch
2 times, most recently
from
2a14a39
to
f901fec
Compare
prashantv
approved these changes
Oct 22, 2023
abhinav
force-pushed
the
parse-stack
branch
2 times, most recently
from
f46c0cd
to
7bdc274
Compare
abhinav
force-pushed
the
strings-contains
branch
from
f901fec
to
25172dd
Compare
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
```
% rg strings.Contains
utils_test.go
84: if strings.Contains(s.State(), "run") {
internal/stack/stacks_test.go
249: if strings.Contains(s.State(), "run") {
```
Resolves #41
abhinav
force-pushed
the
strings-contains
branch
from
25172dd
to
78c5017
Compare
Merged
mway
added a commit
that referenced
this pull request
Oct 24, 2023
### Fixed - Built-in ignores now match function names more accurately. They will no longer ignore stacks because of file names that look similar to function names. (#112) ### Added - Add an `IgnoreAnyFunction` option to ignore stack traces that have the provided function anywhere in the stack. (#113) - Ignore `testing.runFuzzing` and `testing.runFuzzTests` alongside other already-ignored test functions (`testing.RunTests`, etc). (#105) ### Changed - Miscellaneous CI-related fixes. (#103, #108, #114) --------- Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of matching for built-in functions with strings.Contains,
use the parsed stack information to match function names exactly.
Following this change, the only remaining strings.Contains are
to match on the goroutine state:
Resolves #41
Depends on #111