Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user defined log levels #1286

Closed
wants to merge 1 commit into from
Closed

feat: user defined log levels #1286

wants to merge 1 commit into from

Conversation

SoulPancake
Copy link

@SoulPancake SoulPancake commented May 13, 2023 •
edited

This is a starter to the approach for - resolves #1277

sywhang
sywhang requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @SoulPancake , sorry I missed the original issue you were working on but we do not want to add this feature to Zap as this is a backwards incompatible change. See my comment #1277 (comment).

@SoulPancake
Copy link
Author

Understood, Thanks @sywhang Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sywhang sywhang sywhang requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying user defined log level names
2 participants
@SoulPancake @sywhang