Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement logging.Logger interface from go-grpc-middleware/v2 #1379

Open
marcoshuck opened this issue Nov 3, 2023 · 1 comment
Open

Implement logging.Logger interface from go-grpc-middleware/v2 #1379

marcoshuck opened this issue Nov 3, 2023 · 1 comment

Comments

@marcoshuck
Copy link

Is your feature request related to a problem? Please describe.

The go-grpc-middleware version 2 has introduced a new way of handling logging interceptors, making the original grpczap package found in this repository impratical.

Describe the solution you'd like
This suggestion requires implementing the logging.Logger interface from the go-grpc-middleware/v2 package, as described in this example: https://github.com/grpc-ecosystem/go-grpc-middleware/blob/main/interceptors/logging/examples/zap/example_test.go#L17

Describe alternatives you've considered
I've raised this same problem in the go-grpc-middleware repository: grpc-ecosystem/go-grpc-middleware#559 (comment)

Is this a breaking change?
It's not.

@marcoshuck
Copy link
Author

I consider creating a PR in a fork during the upcoming weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant