Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17 release #942

Closed
ptabor opened this issue May 15, 2021 · 4 comments
Closed

1.17 release #942

ptabor opened this issue May 15, 2021 · 4 comments

Comments

@ptabor
Copy link

ptabor commented May 15, 2021

On behalf of https://github.com/etcd-io/etcd wanted to check perspectives for zap-1.17 release.

etcd is currently depending on: go.uber.org/zap v1.16.1-0.20210329175301-c23abee72d19.

The unstable dependency was taken due to 89e3820 (grpclog.LoggerV2).
Now we are preparing etcd release 3.5.0 that is needed to unblock kubernetes 1.22.

The etcd release is tracked by: etcd-io/etcd#12970

@abhinav
Copy link
Collaborator

abhinav commented May 18, 2021

Hey there! We're not opposed to tagging a new release but we might have to back out #897 if we do that right now.

We have someone working on a version of #782 to address some of the outstanding issues. Until that's ready, though, we can't tag a release that includes the new Clock interface (added in #897) because we expect the work in #782 to affect that interface.

CC @prashantv

@ptabor
Copy link
Author

ptabor commented May 18, 2021

Thank you for the response. I think we are talking about ~2 weeks timeline for promoting 3.5.0-beta to 3.5.0 at which state we should have stable dependencies.

@hexfusion
Copy link

Hi @abhinav @ptabor following up on this any chance for a release this week?

@abhinav
Copy link
Collaborator

abhinav commented May 25, 2021

Hey @hexfusion. @prashantv and I decided last week that if we could get our reworked version of #782 in by today, we'd ship that. Otherwise, we'll back out #897 for this release (because it's getting changed in #948).

We'll try to tag the release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants