Drop support for Go < 1.15 #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.12 is old enough that we don't need to try to support it. The files global_go112 and global_prego112 existed to support different stack depths for the standard library logger, which changed going from Go 1.11 to 1.12. This is no longer something we need to support because per our CI configuration, we only support Go 1.15+. Ref #682
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
=======================================
Coverage 98.20% 98.20%
=======================================
Files 47 47
Lines 2067 2067
=======================================
Hits 2030 2030
Misses 29 29
Partials 8 8
Continue to review full report at Codecov.
|
sywhang
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our CI, we don't support versions of Go older than 1.15.
The files global_go112 and global_prego112 existed to
support different stack depths for the standard library logger,
which changed going from Go 1.11 to 1.12 (ref #682).
This is no longer necessary; Go 1.11 is old enough that we don't need
to support it.