Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid release detection when triggered from a stale branch #48

Open
KevinGrandon opened this issue Jul 30, 2018 · 1 comment
Open

Invalid release detection when triggered from a stale branch #48

KevinGrandon opened this issue Jul 30, 2018 · 1 comment

Comments

@KevinGrandon
Copy link
Contributor

When a user opens a pull request with a stale branch with only a change to package.json, we can improperly detect the change as a release. This triggers the error here:

probot-app-label-release-pr/index.js

Line 76 in 9f52991

description: 'Detected release PR, but invalid PR title',

@KevinGrandon
Copy link
Contributor Author

I believe this is what happened here: fusionjs/fusion-plugin-error-handling#139

@rtsao rtsao mentioned this issue Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KevinGrandon