Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Checker Framework dependence to 3.38.0 #819

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 1, 2023

Beyond getting up to date, this is a pre-requisite for addressing #811

@msridhar
Copy link
Collaborator Author

msridhar commented Sep 1, 2023

/benchmark

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all tests pass and benchmarking comes up good :)

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.088 ± 0.102  ops/s
CaffeineBenchmark.compile         thrpt   25   2.069 ± 0.013  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.861 ± 0.387  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.263 ± 0.017  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.129 ± 0.138  ops/s
CaffeineBenchmark.compile         thrpt   25   2.121 ± 0.020  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.571 ± 0.314  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.289 ± 0.019  ops/s

@msridhar
Copy link
Collaborator Author

msridhar commented Sep 1, 2023

Benchmarks look good so will land

@msridhar msridhar enabled auto-merge (squash) September 1, 2023 20:47
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +86.76% 🎉

Comparison is base (b7f1326) 0.00% compared to head (a68660e) 86.76%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #819       +/-   ##
=============================================
+ Coverage          0   86.76%   +86.76%     
- Complexity        0     1863     +1863     
=============================================
  Files             0       74       +74     
  Lines             0     6165     +6165     
  Branches          0     1197     +1197     
=============================================
+ Hits              0     5349     +5349     
- Misses            0      407      +407     
- Partials          0      409      +409     
Files Changed Coverage Δ
...llaway/dataflow/AccessPathNullnessPropagation.java 82.42% <100.00%> (ø)
...uber/nullaway/dataflow/cfg/NullAwayCFGBuilder.java 92.30% <100.00%> (ø)

... and 72 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 7a78bc7 into uber:master Sep 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants