Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat parameter of generated Record.equals() methods as @Nullable #825

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 4, 2023

Fixes #619

@msridhar msridhar marked this pull request as draft September 4, 2023 16:50
@msridhar
Copy link
Collaborator Author

msridhar commented Sep 4, 2023

/benchmark

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.06% ⚠️

Comparison is base (a7b097a) 86.81% compared to head (2db217b) 86.75%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #825      +/-   ##
============================================
- Coverage     86.81%   86.75%   -0.06%     
- Complexity     1863     1870       +7     
============================================
  Files            74       74              
  Lines          6165     6178      +13     
  Branches       1197     1202       +5     
============================================
+ Hits           5352     5360       +8     
- Misses          405      406       +1     
- Partials        408      412       +4     
Files Changed Coverage Δ
...away/src/main/java/com/uber/nullaway/Nullness.java 85.07% <84.61%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.157 ± 0.027  ops/s
CaffeineBenchmark.compile         thrpt   25   2.115 ± 0.011  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.050 ± 0.334  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.262 ± 0.017  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.124 ± 0.103  ops/s
CaffeineBenchmark.compile         thrpt   25   2.134 ± 0.014  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.178 ± 0.201  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.283 ± 0.016  ops/s

@msridhar
Copy link
Collaborator Author

msridhar commented Sep 5, 2023

/benchmark

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 🙂 Quick question and possible documentation nit.

@msridhar msridhar marked this pull request as ready for review September 5, 2023 18:58
@msridhar msridhar enabled auto-merge (squash) September 5, 2023 19:16
@msridhar msridhar merged commit fcaf39e into uber:master Sep 5, 2023
8 of 10 checks passed
@msridhar msridhar deleted the issue-619 branch September 5, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false-positive trigger on java17record.equals(null)
2 participants