Run tests on JDK 21 #826
Merged
Run tests on JDK 21 #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
============================================
+ Coverage 86.75% 86.77% +0.01%
Complexity 1870 1870
============================================
Files 74 74
Lines 6178 6178
Branches 1202 1202
============================================
+ Hits 5360 5361 +1
Misses 406 406
+ Partials 412 411 -1 ☔ View full report in Codecov by Sentry. |
Closed
|
Converted this one to a draft again as I'd like to get rid of at least some of the copy-pasting in the Gradle build files |
|
This is now ready for review again |
lazaroclapp
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like most of our tests pass on JDK 21. Exceptions are the JSpecify generics tests, which rely on an API that changed in JDK 21 (see #827), and the JarInfer tests, as it looks like WALA does not yet support running on JDK 21 (see #829). Core NullAway support (ignoring the experimental/WIP JSpecify mode) should be working. This PR adds test configs so that we run tests on JDK 21 wherever possible. We update our Jacoco and Mockito versions to make this work.
We also take the opportunity to move some common test configuration code to the
nullaway.java-test-conventions.gradlefile, which previously just held configuration for Jacoco.