Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from componentWillReceiveProps #1084

Open
havardh opened this issue Jan 10, 2019 · 8 comments 路 May be fixed by #1253
Open

Migrate away from componentWillReceiveProps #1084

havardh opened this issue Jan 10, 2019 · 8 comments 路 May be fixed by #1253
Labels
chore enhancement

Comments

@havardh
Copy link

havardh commented Jan 10, 2019 •
edited

Hi. 馃憢

By running in react strict-mode, I noticed that that react-vis relies on the now deprecated componentWillReciveProps.

With a quick search in the repo I found the following usages (examples are omitted):

These should be easily resolvable by moving to either getDerivedStateFromProps or componentDidUpdate or memoization as detailed here and here.

Are there any plans for doing or concerns about doing these changes?

If these changes makes sense for the project, I could make a PR for them 馃憤
@mcnuttandrew
Copy link
Contributor

Hey that sounds like great work to be doing! I would love to see a PR to that effect

@taltultc
Copy link

+1

1 similar comment
@fedorov-xyz
Copy link

+1

@TimoPurzner
Copy link

Please fix this or the Project will soon stop working :)
Im getting the warning:

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: FlexibleXYPlot

@DiegoGorgazzi DiegoGorgazzi linked a pull request Oct 18, 2019 that will close this issue
Open
@testacode
Copy link

Same here please!
image

@yukoliesh
Copy link

Is there any update on this?

@tp00012x
Copy link

tp00012x commented Mar 4, 2022

Just close this library if you guys are not going to maintain it well

@PhilippWendler PhilippWendler mentioned this issue Mar 5, 2024
Closed
@av-k
Copy link

av-k commented May 14, 2024

The project exists 8 years, the issue exists 5+ years, is something happening here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor componentWillReceiveProps DiegoGorgazzi/react-vis
9 participants
@havardh @testacode @taltultc @mcnuttandrew @TimoPurzner @av-k @yukoliesh @tp00012x @fedorov-xyz