Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons for the web PWA #191

Merged
merged 1 commit into from Aug 31, 2022
Merged

Add icons for the web PWA #191

merged 1 commit into from Aug 31, 2022

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Aug 31, 2022

  • Remove manifest color definitions to use default background (light or dark)
  • Add title in manifest
  • Add multiple png favicons
  • Use svg in manifest icons

Fixes #164

@Jupi007
Add icons for the web PWA
be39019 
- Remove manifest color definitions to use default background (light or dark)
- Add title in manifest
- Add multiple png favicons
- Use svg in manifest icons

Fixes #164
@Feichtmeier
Copy link
Member

Thank you!
Tried to open this locally in chrome but the PWA button only pops up if I go to the deployed github page
Let's merge and see, really no other idea how to fully test it :)

@Feichtmeier Feichtmeier merged commit 2c1eb4d into main Aug 31, 2022
@Feichtmeier
Copy link
Member

Works :) 🥂

grafik

@Jupi007 Jupi007 deleted the Jupi007/issue164 branch August 31, 2022 10:06
@Jupi007
Copy link
Member Author

Jupi007 commented Aug 31, 2022

Hooray 🥳

@Feichtmeier
Copy link
Member

I hope this knowledge is at least useful for you other flutter web projects? :)

@Jupi007
Copy link
Member Author

Jupi007 commented Aug 31, 2022

Ofc, even more, it is useful for any of my web projects :D
It is always hard to work with all those favicon, and know what to do.
Here I have a good working base I think.

Feichtmeier pushed a commit that referenced this pull request Feb 22, 2024
@robert-ancell
Replace deprecated arguments with replacements (#191)
ad45758
Feichtmeier pushed a commit that referenced this pull request Feb 22, 2024
@jpnurmi
Set minimum Flutter version to 3.3.0 (#194)
b9cf4cd 
New API used in #191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add icons for the web PWA
2 participants
@Jupi007 @Feichtmeier