Remove YaruAlertDialg and YaruSimpleDialog

[Feichtmeier]

Eventually we should just remove those dialogs from yaruwidgets as they do not bring anything really except complexity. What one wants is the close button the rest can be done by the content inside or the dialog theme in yaru.dart

WDYT @Jupi007 ?

[Jupi007]

Yes, we just want the close button, and the correct padding. If this last can be defined in the theme, those dialog widgets can be removed.

[jpnurmi]

What kind of padding properties do we need in DialogTheme?

[Feichtmeier]

For yarudialogtitle, which is a stack of the title widget and the close button, the title padding needs to be zero
Content padding does not interfere with the close button
But I'm not sure if this is an the best way

[Jupi007]

Well the default dialog padding is EdgeInsets.fromLTRB(0.0, 12.0, 0.0, 16.0), but it looks weird.
Yaru*Dialog was define a padding of 20 on each side, and also it removes it for the title.

[Feichtmeier]

Eventually this could be added to flutter itself?

[Jupi007]

I also think so, it would be quite simple to implement.

[jpnurmi]

Would adding DialogTheme.contentPadding and titlePadding be enough? Unfortunately, DialogTheme is one of those old theme classes that don't follow the theme data pattern. It should have the same treatment as ListTileTheme recently did.

[Jupi007]

It would be enough, yes :)

[Feichtmeier]

The content padding is tricky, I would not overwrite this with the theme. Some dialogues need an even content padding, other do not
I would eventually only add the title padding

[Jupi007]

But define a better default content padding wouldn't hurt, no?
You would still be able to overwrite it, indeed :)

[Feichtmeier]

Ofc, you are right 👍
I don't remember the default padding, is it huge?

[Jupi007]

I posted it upper ;D
It is EdgeInsets.fromLTRB(0.0, 12.0, 0.0, 16.0), and honesty this looks weird (look at the fullscreen carousel padding in software app).

[Feichtmeier]

Eventually just set the default padding yaru.dart to EdgeInsets.zero ? I fear dialogues could be so diverse that not default padding fits more than 2 or 3 cases