Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version constraints #207

Merged
merged 1 commit into from Sep 18, 2022
Merged

Fix version constraints #207

merged 1 commit into from Sep 18, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Sep 18, 2022

No description provided.

@@ -5,8 +5,8 @@ homepage: https://github.com/ubuntu/yaru_widgets.dart
version: 1.1.3

environment:
sdk: ">=2.17.0 <3.3.2"
flutter: ">=3.3.2"
sdk: ">=2.17.0 <3.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the Dart SDK i.e. the language version. anything less than 3.0 is accepted but 3.0 is not because it's going to incompatible

sdk: ">=2.17.0 <3.3.2"
flutter: ">=3.3.2"
sdk: ">=2.17.0 <3.0.0"
flutter: ">=3.3.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

people are strongly encouraged to upgrade to 3.3.2 because of the important bug fixes but technically (API-wise) only 3.3.0 is required

@Feichtmeier
Copy link
Member

Feichtmeier commented Sep 18, 2022

Thank you for the enlightening comments 👍 😸
I was really not aware what those props all mean

@Feichtmeier Feichtmeier merged commit 947f293 into ubuntu:main Sep 18, 2022
@jpnurmi jpnurmi deleted the fix-version-constraints branch September 18, 2022 08:21
Feichtmeier added a commit that referenced this pull request Sep 21, 2022
- [Frederik Feichtmeier](https://github.com/Feichtmeier)
  - YaruCompactLayout: simplify and remove appbar mode (#212)
  - WideLayout: add yaru transition (#210)
- [J-P Nurmi](https://github.com/jpnurmi)
  - Fix version constraints (#207)
- [Paul Kepinski](https://github.com/Jupi007)
  - Hide control buttons when first/last page reached (#209)
@Feichtmeier Feichtmeier mentioned this pull request Sep 21, 2022
Feichtmeier added a commit that referenced this pull request Sep 21, 2022
- [Frederik Feichtmeier](https://github.com/Feichtmeier)
  - YaruCompactLayout: simplify and remove appbar mode (#212)
  - WideLayout: add yaru transition (#210)
- [J-P Nurmi](https://github.com/jpnurmi)
  - Fix version constraints (#207)
- [Paul Kepinski](https://github.com/Jupi007)
  - Hide control buttons when first/last page reached (#209)
Feichtmeier pushed a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants