Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for arrows on image carousel #208

Closed
madsrh opened this issue Sep 18, 2022 · 8 comments · Fixed by #209
Closed

Enhancement for arrows on image carousel #208

madsrh opened this issue Sep 18, 2022 · 8 comments · Fixed by #209
Assignees

Comments

@madsrh
Copy link
Member

madsrh commented Sep 18, 2022

The difference between the active and deactivated arrows in the image carousel are too subtle IMHO. I think a better solution would be if the images could just loop ♾️ or alternatively, to hide the left arrow on the first image (and right arrow for the last ofc).

For accessibility the keyboard left/right arrows should work when I click the arrows, the dots and when the image is enlarged.

image

@Feichtmeier
Copy link
Member

looping is a parameter which sometimes makes sense, sometimes not. so I would not override this with a hardocded bool honestly

@madsrh
Copy link
Member Author

madsrh commented Sep 19, 2022

@Jupi007 would it be possible to a border-radius to the image? This way it would fit the other parts of the UI

@Jupi007
Copy link
Member

Jupi007 commented Sep 19, 2022

@madsrh Yes it would be possible 👍 :)

@Jupi007
Copy link
Member

Jupi007 commented Sep 20, 2022

@madsrh I forgotten about the keyboard thing, so reopening :)

About the border-radius, imo this should be done by the app using the carousel (aka. Software).

@Jupi007 Jupi007 reopened this Sep 20, 2022
@Feichtmeier
Copy link
Member

Yes this can be done inside the app
The carousel only contains what's given @madsrh

@madsrh
Copy link
Member Author

madsrh commented Sep 23, 2022

@Jupi007 Are the (missing) keyboard bindings for fullscreen done here or in the Software app? 🤔

Also, can the left / right arrows be present in fullscreen mode?

@Feichtmeier
Copy link
Member

It's not missing in software you just need to click on the image :D

@madsrh
Copy link
Member Author

madsrh commented Sep 23, 2022

It's not missing in software you just need to click on the image :D

Nope, this is the latest master:

image

Feichtmeier added a commit that referenced this issue Feb 22, 2024
* Add PopupMenuTheme and improve example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants