Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NarrowLayout: sync selection style with WideLayout selection #211

Closed
Feichtmeier opened this issue Sep 20, 2022 · 4 comments · Fixed by #212
Closed

NarrowLayout: sync selection style with WideLayout selection #211

Feichtmeier opened this issue Sep 20, 2022 · 4 comments · Fixed by #212

Comments

@Feichtmeier
Copy link
Member

Posted by @madsrh in https://github.com/ubuntu-flutter-community/software/issues/234

ATM active selections have both icon and label colored:
image

We should only add color to the "pill" background and change the text weight.

https://api.flutter.dev/flutter/material/NavigationBar-class.html

image

This is an issue in material.dart in the stable channel not being 100% material 3 compatible
I think, when they are done with the migration this issue should be resolved for us "automatically"
@Jupi007
Copy link
Member

Jupi007 commented Sep 20, 2022 •
edited

I was thinking about something: do we really need this bottom rail when the window width is small?
I explain myself: the left rail bar is quite small, and if you have many like ~6-8 items, when you resize the window, the bottom bar becomes too small in width to correctly display all those items.

@Feichtmeier
Copy link
Member Author

I thought the same, in this specific app we absolute do not need it.

The mouse travel becomes extraordinary large when the layout switches

Eventually it's not needed at all on the desktop?

@madsrh
Copy link
Member

madsrh commented Sep 20, 2022

do we really need this bottom rail when the window width is small?

No, good point @Jupi007

Feichtmeier added a commit that referenced this issue Sep 20, 2022
@Feichtmeier
YaruCompactLayout: simplify and remove appbar mode
440748a 
- as discussed in #211 the NarrowLayout looks different than the WideLayout and also has not much sense for when there are more than 3 or 4 items. The NarrowLayout is also bad for mouse travel on the desktop
- thus this commit removes the layout builder inside compact layout which still leaves the compact layout with three possible widths modes

Closes #211
@Feichtmeier Feichtmeier mentioned this issue Sep 20, 2022
Merged
@Feichtmeier
Copy link
Member Author

Just in case anyone wants it back :D

The new layout that looks like the navigationrail is named navigationbar
https://api.flutter.dev/flutter/material/NavigationBar-class.html

Feichtmeier pushed a commit that referenced this issue Feb 22, 2024
@jpnurmi
Use G_DECLARE_FINAL_TYPE to fix build with flutter-snap (#211)
c1edf4b 
The Clang version in core18-based flutter-snap is not happy with
`G_DEFINE_AUTOPTR_CLEANUP_FUNC`. Using `G_DECLARE_FINAL_TYPE` gives
autoptr support in a way that makes the old Clang happy.

Fixes: #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

YaruCompactLayout: simplify and remove appbar mode ubuntu/yaru.dart
3 participants
@madsrh @Feichtmeier @Jupi007