Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Login v2.1 update request which I've done #172

Open
MTheProgrammer opened this issue Oct 28, 2022 · 4 comments
Open

Line Login v2.1 update request which I've done #172

MTheProgrammer opened this issue Oct 28, 2022 · 4 comments

Comments

@MTheProgrammer
Copy link

MTheProgrammer commented Oct 28, 2022

Problem Statement

Hi, I've created an updated ingegration for Line Login that supports their new API v2.1. Current integration does not work and the maintainer is not responding.

Shall I add this as a new integration or replace the old url? Should it added to hex under my namespace?

It needs some polishing yet, however I should be done with it soon:
https://github.com/LucidModules/ueberauth_line

Solution Brainstorm

No response

@yordis
Copy link
Member

yordis commented Oct 28, 2022

Maybe @alexfilatov would prefer to move the implementation under Ueberauth organization 🤷🏻

@alexfilatov
Copy link

Happy to do so @yordis

@alexfilatov
Copy link

alexfilatov commented Oct 28, 2022

@MTheProgrammer sorry, looks like I missed your PR completely, just merged, thank you! 🙏

Just looked at your fork, really good job! You can make a PR against my repo and after that I will move it under the ueberauth org.

@MTheProgrammer
Copy link
Author

MTheProgrammer commented Oct 28, 2022

@alexfilatov Thank you, I had to rewrite the library because Line Login API v2.1 does not return necessary user details. You have to request it from another endpoint.
I haven't yet resolved the optional nonce check feature which strengthens the security. As I am relatively fresh to Elixir would you mind providing your insights on how to implement that feature? Whether a GenServer is sufficient or shall we use Mnesia to ensure the nonce uniqueness in multi-node environment.

Here are docs about PKCE compatibility:
https://developers.line.biz/en/docs/line-login/integrate-pkce/#pkce-merit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants