fix(link): fixes links with marks (#6078)

GormanDesign · bdbch · web-flow · commit 9a0af5dfeb99 · 2025-03-31T02:14:58.000+02:00
* fixes links with marks

* Create popular-geckos-pay.md

* Update clickHandler.ts

---------

Co-authored-by: bdbch &lt;6538827+bdbch@users.noreply.github.com&gt;
diff --git a/.changeset/popular-geckos-pay.md b/.changeset/popular-geckos-pay.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/extension-link": patch
+---
+
+Fixed links with marks not registering click events correctly
diff --git a/packages/extension-link/src/helpers/clickHandler.ts b/packages/extension-link/src/helpers/clickHandler.ts
@@ -19,21 +19,28 @@ export function clickHandler(options: ClickHandlerOptions): Plugin {
           return false
         }
 
-        let a = event.target as HTMLElement
-        const els = []
-
-        while (a.nodeName !== 'DIV') {
-          els.push(a)
-          a = a.parentNode as HTMLElement
+        let link: HTMLAnchorElement | null = null
+
+        if (event.target instanceof HTMLAnchorElement) {
+          link = event.target
+        } else {
+          let a = event.target as HTMLElement
+          const els = []
+
+          while (a.nodeName !== 'DIV') {
+            els.push(a)
+            a = a.parentNode as HTMLElement
+          }
+          link = els.find(
+            value => value.nodeName === 'A',
+          ) as HTMLAnchorElement
         }
 
-        if (!els.find(value => value.nodeName === 'A')) {
+        if (!link) {
           return false
         }
 
         const attrs = getAttributes(view.state, options.type.name)
-        const link = (event.target as HTMLAnchorElement)
-
         const href = link?.href ?? attrs.href
         const target = link?.target ?? attrs.target
 
