Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destroyed view causing errors on dispatchTransaction #3799

Merged
merged 1 commit into from Feb 28, 2023
Merged

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Feb 27, 2023

This PR should fix the issue #3798

There should be no errors anymore if the view is not existent anymore.

close #3798

@bdbch bdbch self-assigned this Feb 27, 2023
@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 966959f
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/63fd3c547d2d470007d8f5a8
😎 Deploy Preview https://deploy-preview-3799--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch changed the title fix(core): fix destroyed view causing errors on dispatchTransaction Fix destroyed view causing errors on dispatchTransaction Feb 27, 2023
@bdbch bdbch merged commit 3c07ca0 into main Feb 28, 2023
@bdbch bdbch deleted the bdbch/issue3798 branch February 28, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix errors that surface due to running commands on an already-destroyed editor
2 participants