fix: Update peerDependencies to fix lerna version tasks #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbch
added
Status: Review
Category: Open Source
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
force-pushed
the
feature/release-deps-fix
branch
from
aff7d57
to
b621aff
Compare
svenadlung
approved these changes
Mar 30, 2023
bdbch
added a commit
that referenced
this pull request
Mar 30, 2023
* v2.1.0-rc.0 * revert version to 2.0.0 * dev: temporarily disable commits for release * dev: set back lerna version * disable commits for releases by default * chore(core): add peerDeps * chore(extension-blockquote): add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: revert 2.1.0 test changes * chore: allow react 17 and upwards * chore: update package-lock.json * chore: move y-prosemirror to peerDeps * chore: move y-prosemirror to dev deps * chore: move y-prosemirror to dev deps
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
) * v2.1.0-rc.0 * revert version to 2.0.0 * dev: temporarily disable commits for release * dev: set back lerna version * disable commits for releases by default * chore(core): add peerDeps * chore(extension-blockquote): add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: revert 2.1.0 test changes * chore: allow react 17 and upwards * chore: update package-lock.json * chore: move y-prosemirror to peerDeps * chore: move y-prosemirror to dev deps * chore: move y-prosemirror to dev deps
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
) * v2.1.0-rc.0 * revert version to 2.0.0 * dev: temporarily disable commits for release * dev: set back lerna version * disable commits for releases by default * chore(core): add peerDeps * chore(extension-blockquote): add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: revert 2.1.0 test changes * chore: allow react 17 and upwards * chore: update package-lock.json * chore: move y-prosemirror to peerDeps * chore: move y-prosemirror to dev deps * chore: move y-prosemirror to dev deps
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
) * v2.1.0-rc.0 * revert version to 2.0.0 * dev: temporarily disable commits for release * dev: set back lerna version * disable commits for releases by default * chore(core): add peerDeps * chore(extension-blockquote): add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: revert 2.1.0 test changes * chore: allow react 17 and upwards * chore: update package-lock.json * chore: move y-prosemirror to peerDeps * chore: move y-prosemirror to dev deps * chore: move y-prosemirror to dev deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes issues we ran into with lerna not being able to update our package-lock because of invalid peerDependencies. This PR solves this issue.
It also includes a change for the versioning task. The version task now won't push and commit automatically anymore. I think it's a good idea, because that way the developer can:
Sure makes things a bit more complicated but also allows for more fine grained control.
How did you accomplish your changes
I went through all packages one by one and replaced the peerDependencies to their correct versions.
How have you tested your changes
I created local test versions including new package-lock files and it worked out fine. bumped up to
2.1.0-pre.0for a test.How can we verify your changes
Clone my pull request and run
npm run release:minor:preand see if the versions + the package-lock are updated.Remarks
Nothing to add here.
Checklist
Related issues
No related issues.