Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot enter full-width characters correctly after toggleBold on Nuxt #5079

Open
1 of 2 tasks
y-negishi opened this issue Apr 18, 2024 · 4 comments
Open
1 of 2 tasks
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@y-negishi
Copy link

Which packages did you experience the bug in?

core, extension-bold, pm, vue-3

What Tiptap version are you using?

2.3.0

What’s the bug you are facing?

  1. editor.chain().focus().toggleBold().run()
  2. Enter full-width characters (ex: あ) 3 times
  3. input ああああ

What browser are you using?

Chrome

Code example

https://stackblitz.com/edit/nuxt-starter-hu71q3?file=package.json,app.vue,nuxt.config.ts

What did you expect to happen?

If you type three times, it should be あああ, but one more character has been typed.
The cursor position seems to have changed after toggleBold.
This happens not only with toggleBold, but also with toggleItalic, setBold, and unsetBold.
It also happens with full-width English (A) characters as well as kana characters such as .

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@y-negishi y-negishi added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Apr 18, 2024
@y-negishi
Copy link
Author

I downgraded the version of prosemirror-view from 1.33.4 to 1.32.7 explicitly in package.json and it works fine.
I do not know if this is a TipTap issue, Prosemirror issue, Nuxt issue or otherwise.

@devunt
Copy link

devunt commented Apr 20, 2024

Also happens in Korean characters. Composition of Hangul characters are broken after v2.3.0.

@devunt
Copy link

devunt commented Apr 20, 2024

This seems most likely caused by ProseMirror/prosemirror-view@a2af570.
Downgrading prosemirror-view to 1.33.2 solves the issue.

I've created the issue on their side: ProseMirror/prosemirror#1458, too.

@Lwrless
Copy link
Sponsor

Lwrless commented May 16, 2024

This was fixed three weeks ago in prosemirror-view 1.33.5 (ProseMirror/prosemirror-view@ab8fa82), so I think we should now be able to upgrade to a later version of prosemirror-view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

3 participants