[Bug]: why change isNodeEmpty behavior on a patch version?

[tdawn0-0]

Affected Packages

core

Version(s)

2.5.7

Bug Description

the helper function isNodeEmpty behavior is change on the 2.5.7.
this will cause the editor isEmpty return true when the editor is only contain a image content.
#5393

Browser Used

Chrome

Code Example URL

No response

Expected Behavior

isNodeEmpty behavior as usual on 2.5.x.

Additional Context (Optional)

No response

Dependency Updates

• Yes, I've updated all my dependencies.

[romansp]

Also noticed that due to this change placeholder is now displayed unexpectedly. For example, if paragraph consists of just mentions or emoji nodes the whole paragraph is now considered to be empty.

This is currently reproducible on templates.tiptap.dev.

[nperez0111]

Sorry this was an oversight in the test cases, surprisingly it is not easy to know what is considered "empty"

[tdawn0-0]

Sorry this was an oversight in the test cases, surprisingly it is not easy to know what is considered "empty"

I understand that this is not a simple task. just changing a fundamental function in a patch version should be approached with more caution.

[nperez0111]

I understand that this is not a simple task. just changing a fundamental function in a patch version should be approached with more caution.

Obviously I did not intend to change the behavior of it. Mistakes can happen. Please reconsider berating maintainers of free OSS software.

[arendjantetteroo]

We add our own components to the page, which tiptap now considers empty since version 2.5.7.
This caused it to sent empty page data to our backend, basically deleting all content of our customers on this page, leading to data loss for these customers.

How can i test the new version works correctly for our usecase?

For example, we define a custom file component:
{"type":"fileComponent","attrs":{"fileId":"id","filename":"Test filename"}}

https://tiptap.dev/docs/editor/extensions/custom-extensions/create-new#create-a-node
On that page there is no mention that you need to handle a isNodeEmtpy check for custom code.

[tdawn0-0]

I understand that this is not a simple task. just changing a fundamental function in a patch version should be approached with more caution.

Obviously I did not intend to change the behavior of it. Mistakes can happen. Please reconsider berating maintainers of free OSS software.

I'm here to discuss a matter. Please accept my apologies if it appeared that I was criticizing you. However, the changes in question are not insignificant.

[nperez0111]

This is now released with v2.5.9