Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ui-router/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.0.14
Choose a base ref
...
head repository: ui-router/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.0.16
Choose a head ref
  • 20 commits
  • 41 files changed
  • 4 contributors

Commits on Jan 17, 2018

  1. feat(common): Add map-in-place support to map()

    @christopherthielen
    christopherthielen committed Jan 17, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    12bc7d8 View commit details

  2. chore(tslint): run tslint --fix on the typescript tests

    @christopherthielen
    christopherthielen committed Jan 17, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b95b0ca View commit details

Commits on Jan 20, 2018

  1. feat(common): Add onEvict() callback registry for queues with max length

    @christopherthielen
    christopherthielen committed Jan 20, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    c19d007 View commit details

  2. chore(lint): lint commonSpec

    @christopherthielen
    christopherthielen committed Jan 20, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    eaff405 View commit details

  3. chore(package): update rollup-plugin-uglify to version 3.0.0

    @greenkeeper
    greenkeeper[bot] committed Jan 20, 2018
    Copy the full SHA
    9bc0924 View commit details

  4. chore(package): update lockfile 

    https://npm.im/greenkeeper-lockfile
    @greenkeeperio-bot
    greenkeeperio-bot committed Jan 20, 2018
    Copy the full SHA
    2709cbe View commit details

Commits on Jan 21, 2018

  1. fix(core): Fix memory leak of resolve data from ALL transitions ever 

    The treeChanges object has references to the PathNodes from the previous transition (`.treeChanges("from")`).
The PathNode object has resolve data inside it.
The previous transition is reachable via a resolve (via tokens: `"$transition$"` or `Transition`).
Through this chain, all other transitions are reachable and not eligible for GC.

This change cleans out the previous Transition object from the resolves, but only
after a transition has been evicted from the `successfulTransitions` queue.
The `successfulTransitions` queue currently has a max size of 1, so the transition
is cleaned up once it is no longer the current nor previous transition
(it is cleaned when it's the previous previous transition);

Fixes #55
Fixes angular-ui/ui-router#3603
Fixes ui-router/angular#21
    @christopherthielen
    christopherthielen committed Jan 21, 2018
    4
    Copy the full SHA
    7f2aed1 View commit details

  2. refactor(pathNode): move clone() from static to instance method

    @christopherthielen
    christopherthielen committed Jan 21, 2018
    Copy the full SHA
    ab9d0f9 View commit details

Commits on Jan 25, 2018

  1. chore(travis): on_success: change

    @christopherthielen
    christopherthielen committed Jan 25, 2018
    Copy the full SHA
    8172697 View commit details

Commits on Jan 26, 2018

  1. Merge pull request #114 from ui-router/greenkeeper/rollup-plugin-ugli… 

    …fy-3.0.0

Update rollup-plugin-uglify to the latest version 🚀
    @christopherthielen
    christopherthielen authored Jan 26, 2018
    Copy the full SHA
    b1b26ff View commit details

  2. chore(travis): on_success: change

    @christopherthielen
    christopherthielen committed Jan 26, 2018
    Copy the full SHA
    4fea758 View commit details

  3. chore(*): Update deps

    @christopherthielen
    christopherthielen committed Jan 26, 2018
    Copy the full SHA
    fe06ce8 View commit details

  4. chore(*): Update deps

    @christopherthielen
    christopherthielen committed Jan 26, 2018
    Copy the full SHA
    bb36c71 View commit details

Commits on Jan 27, 2018

  1. Revert "refactor(treeChanges): Simplify variables when calculating tr… 

    …ee changes"

This reverts commit f65cfb3
Also adds retainedWithToParams
    @christopherthielen
    christopherthielen committed Jan 27, 2018
    Copy the full SHA
    632ed4f View commit details

Commits on Jan 28, 2018

  1. fix(pathNode): add backwards compat for PathNode.clone(). Add retaine… 

    …dWithToParams to treeChanges interface.
    @christopherthielen
    christopherthielen committed Jan 28, 2018
    Copy the full SHA
    4833a32 View commit details

  2. chore(rollup): update rollup config

    @christopherthielen
    christopherthielen committed Jan 28, 2018
    Copy the full SHA
    5baeed4 View commit details

  3. test(sticky-states): Add sticky-states to test:downstream projects

    @christopherthielen
    christopherthielen committed Jan 28, 2018
    Copy the full SHA
    5ce7aed View commit details

  4. 5.0.15

    @christopherthielen
    christopherthielen committed Jan 28, 2018
    Copy the full SHA
    5a78f47 View commit details

Commits on Jan 30, 2018

  1. fix(common): Fix signature of for objects (make target optional)

    @christopherthielen
    christopherthielen committed Jan 30, 2018
    Copy the full SHA
    61d0afc View commit details

  2. 5.0.16

    @christopherthielen
    christopherthielen committed Jan 30, 2018
    Copy the full SHA
    df0c3e3 View commit details
Loading