Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ui-router/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.0.3
Choose a base ref
...
head repository: ui-router/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.0.4
Choose a head ref
  • 5 commits
  • 6 files changed
  • 3 contributors

Commits on Dec 31, 2019

  1. docs(lazyLoad): Switch from System.import() to import()

    @christopherthielen
    christopherthielen committed Dec 31, 2019
    Copy the full SHA
    ebcc6f2 View commit details

Commits on Jan 6, 2020

  1. build(deps-dev): bump rollup from 1.27.14 to 1.28.0 

    Bumps [rollup](https://github.com/rollup/rollup) from 1.27.14 to 1.28.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v1.27.14...v1.28.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    @dependabot-preview
    dependabot-preview[bot] authored Jan 6, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    b93c761 View commit details

  2. Merge pull request #508 from ui-router/dependabot/npm_and_yarn/rollup… 

    …-1.28.0
    @dependabot-preview
    dependabot-preview[bot] authored Jan 6, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    244effb View commit details

  3. fix(safeConsole): check if document is defined to avoid issues in nod… 

    …e environments
    @mergify
    Rafael Fernandez Serra authored and mergify[bot] committed Jan 6, 2020
    Copy the full SHA
    da29d88 View commit details

  4. 6.0.4

    @christopherthielen
    christopherthielen committed Jan 6, 2020
    Copy the full SHA
    cd22e7f View commit details
Showing with 18 additions and 8 deletions.
  1. +10 −0 CHANGELOG.md
  2. +1 −1 package.json
  3. +1 −1 src/common/safeConsole.ts
  4. +1 −1 src/hooks/lazyLoad.ts
  5. +2 −2 src/state/interface.ts
  6. +3 −3 yarn.lock
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## 6.0.4 (2020-01-06)
[Compare `@uirouter/core` versions 6.0.3 and 6.0.4](https://github.com/ui-router/core/compare/6.0.3...6.0.4)

### Bug Fixes

* **safeConsole:** check if document is defined to avoid issues in node environments ([da29d88](https://github.com/ui-router/core/commit/da29d88))




## 6.0.3 (2019-12-30)
[Compare `@uirouter/core` versions 6.0.2 and 6.0.3](https://github.com/ui-router/core/compare/6.0.2...6.0.3)

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@uirouter/core",
"description": "UI-Router Core: Framework agnostic, State-based routing for JavaScript Single Page Apps",
"version": "6.0.3",
"version": "6.0.4",
"scripts": {
"clean": "shx rm -rf lib lib-esm _bundles .cache _doc",
"compile": "npm run clean && tsc && tsc -m es6 --outDir lib-esm && shx cp src/*.json lib",
2 changes: 1 addition & 1 deletion src/common/safeConsole.ts
View file
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ function fallbackConsole(console) {

function getSafeConsole() {
// @ts-ignore
const isIE9 = document && document.documentMode && document.documentMode === 9;
const isIE9 = typeof document !== 'undefined' && document.documentMode && document.documentMode === 9;
if (isIE9) {
return window && window.console ? ie9Console(window.console) : noopConsoleStub;
} else if (!console.table || !console.error) {
2 changes: 1 addition & 1 deletion src/hooks/lazyLoad.ts
View file
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ import { StateRule } from '../url/interface';
* ```
* .state('abc', {
* component: 'fooComponent',
* lazyLoad: () => System.import('./fooComponent')
* lazyLoad: () => import('./fooComponent')
* });
* ```
*
4 changes: 2 additions & 2 deletions src/state/interface.ts
View file
Original file line number Diff line number Diff line change
@@ -563,7 +563,7 @@ export interface StateDeclaration {
*
* ```
* .state('abc', {
* lazyLoad: (transition, state) => System.import('./abcService')
* lazyLoad: (transition, state) => import('./abcService')
* }
* ```
*
@@ -621,7 +621,7 @@ export interface StateDeclaration {
* {
* name: 'parent.**',
* url: '/parent',
* lazyLoad: () => System.import('./lazy.states.js')
* lazyLoad: () => import('./lazy.states.js')
* }
* ```
*
6 changes: 3 additions & 3 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -4033,9 +4033,9 @@ rollup-pluginutils@^2.0.1, rollup-pluginutils@^2.8.1:
estree-walker "^0.6.1"

rollup@^1.15.5:
version "1.27.14"
resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.27.14.tgz#940718d5eec1a6887e399aa0089944bae5c4f377"
integrity sha512-DuDjEyn8Y79ALYXMt+nH/EI58L5pEw5HU9K38xXdRnxQhvzUTI/nxAawhkAHUQeudANQ//8iyrhVRHJBuR6DSQ==
version "1.28.0"
resolved "https://registry.yarnpkg.com/rollup/-/rollup-1.28.0.tgz#d576a6a0fd7490b2e1f531ef8b411795fb80da87"
integrity sha512-v2J/DmQi9+Nf6frGqzwZRvbiuTTrqH0yzoUF4Eybf8sONT4UpLZzJYnYzW96Zm9X1+4SJmijfnFBWCzHDAXYnQ==
dependencies:
"@types/estree" "*"
"@types/node" "*"