fix: Fix value props controlled issue. #199

uiwjs · Oct 14, 2021 · 29a3145 · 29a3145
1 parent 24eb08b
commit 29a3145
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/useCodeMirror.ts b/src/useCodeMirror.ts
@@ -104,9 +104,11 @@ export function useCodeMirror(props: UseCodeMirror) {
   useEffect(() => {
     if (view) {
       const currentValue = view.state.doc.toString();
-      view.dispatch({
-        changes: { from: 0, to: currentValue.length, insert: value || '' },
-      });
+      if (value !== currentValue) {
+        view.dispatch({
+          changes: { from: 0, to: currentValue.length, insert: value || '' },
+        });
+      }
     }
   }, [value, view]);
 

diff --git a/website/App.tsx b/website/App.tsx
@@ -193,9 +193,7 @@ export default function App() {
         autoFocus={autofocus}
         className={styles.codemirror}
         placeholder={placeholder}
-        onChange={(value) => {
-          // console.log('value:', value);
-        }}
+        onChange={(value) => setCode(value)}
         style={{
           maxWidth: '995px',
           margin: '-18px auto 0 auto',