fix(react-codemirror): unexpected effect called when extension is null (

#542)
uiwjs · Jul 21, 2023 · bed5e80 · bed5e80
1 parent 528759f
commit bed5e80
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/core/src/useCodeMirror.ts b/core/src/useCodeMirror.ts
@@ -1,5 +1,5 @@
 import { useEffect, useState } from 'react';
-import { Annotation, EditorState, StateEffect } from '@codemirror/state';
+import { Annotation, EditorState, StateEffect, type Extension } from '@codemirror/state';
 import { EditorView, ViewUpdate } from '@codemirror/view';
 import { getDefaultExtensions } from './getDefaultExtensions';
 import { getStatistics } from './utils';
@@ -11,6 +11,8 @@ export interface UseCodeMirror extends ReactCodeMirrorProps {
   container?: HTMLDivElement | null;
 }
 
+const emptyExtensions: Extension[] = [];
+
 export function useCodeMirror(props: UseCodeMirror) {
   const {
     value,
@@ -19,7 +21,7 @@ export function useCodeMirror(props: UseCodeMirror) {
     onStatistics,
     onCreateEditor,
     onUpdate,
-    extensions = [],
+    extensions = emptyExtensions,
     autoFocus,
     theme = 'light',
     height = '',