New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Expose "root" props of EditorView #202
Comments
@noru Welcome to submit a PR, I can provide some help. |
react-codemirror/src/useCodeMirror.ts Line 141 in 24af229
|
hi @jaywcjlove, a PR(#204) is sent. appreciated your help! |
jaywcjlove
added a commit
that referenced
this issue
Oct 15, 2021
jaywcjlove
added a commit
that referenced
this issue
Oct 15, 2021
@noru Upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Maintainer,
Could you please expose "root" config of EditorView (https://codemirror.net/6/docs/ref/#view.EditorView.constructor^config.root)?
I'm using shadow dom in my case, without this config the whole style would go broken. And there is no workaround currently.
I've read the code, seems only
container
is exposed byuseCodeMirror
hook, sadly that's not sufficient for cases using shadow dom.I would be happy to submit a PR for this request. Just drop me some guidance if needed. The simple change would be add a prop just like
container
, but it would be better to expose all configs ofstate/view
for better customization.The text was updated successfully, but these errors were encountered: