Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useCodeMirror overwrites content if not provided via prop #441

Closed
mrdrogdrog opened this issue Dec 28, 2022 · 3 comments · Fixed by #442
Closed

useCodeMirror overwrites content if not provided via prop #441

mrdrogdrog opened this issue Dec 28, 2022 · 3 comments · Fixed by #442

Comments

@mrdrogdrog
Copy link
Contributor

mrdrogdrog commented Dec 28, 2022 •
edited
Loading

Greetings

Hello 👋 Nice work. ❤️

Problem

In useCodeMirror.ts you have an effect which overwrites the document content every time the variable value changes.
I use the react-codemirror component in a project where the content comes from a codemirror extension and not via your prop but the effect still triggers on init and overwrites my initial content.

Prefered solution

I can't provide the content via the prop so it would be nice to disable this effect. Please don't execute the dispatch in the effect if no content (null or undefined) was given.
@mrdrogdrog mrdrogdrog changed the title useCodeMirror overwrites content every time useCodeMirror overwrites content if not provided via prop Dec 28, 2022
@jaywcjlove
Copy link
Member

@mrdrogdrog Welcome to submit PR

@mrdrogdrog
Copy link
Contributor Author

@jaywcjlove Very gladly! I'm creating it right now

mrdrogdrog added a commit to mrdrogdrog/react-codemirror that referenced this issue Dec 29, 2022
@mrdrogdrog
fix(core): don't set editor content if value is undefined uiwjs#441

Verified

This commit was signed with the committer’s verified signature.
mrdrogdrog Mr. DrogDrog
GPG key ID: 42498463316F048B
Verified
Learn about vigilant mode
02a7f28
@mrdrogdrog mrdrogdrog mentioned this issue Dec 29, 2022
Merged
jaywcjlove pushed a commit that referenced this issue Dec 30, 2022
@mrdrogdrog
fix(core): don't set editor content if value is undefined #441 (#442)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0551523
jaywcjlove added a commit that referenced this issue Dec 30, 2022
@jaywcjlove
released v4.19.5 #441 (#442)
c03ce40
github-actions bot pushed a commit that referenced this issue Dec 30, 2022
@jaywcjlove
v4.19.4 fix(core): don't set editor content if value is undefined #441 (
3fb4303 
#442) 0551523
github-actions bot pushed a commit that referenced this issue Dec 30, 2022
@jaywcjlove
v4.19.5 released v4.19.5 #441 (#442) c03ce40
1222b42
@jaywcjlove
Copy link
Member

@mrdrogdrog upgrade v4.19.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): don't set editor content if value is undefined uiwjs#441 mrdrogdrog/react-codemirror
2 participants
@jaywcjlove @mrdrogdrog