-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[themes] export theme settings separately for external use #457
Comments
I didn't think there was any problem, so I added it. |
jaywcjlove
added a commit
that referenced
this issue
Feb 10, 2023
jaywcjlove
added a commit
that referenced
this issue
Feb 10, 2023
thanks for the quick fix! for some reason, the new versions (4.19.8) do not contain the export yet, the code on npm still looks like this: |
@felixroos Upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! I am just trying out the themes and they are really easy to use and look great inside the editor!
To be able to reuse the theme colors for other elements of the page, it would be great if the settings would be exported separately.
I tried to find a way to deduce the settings from the exported theme object, but the standardized keys
background
,foreground
,caret
, ... etc are gone. Also, the structure of that (huge) exported theme object seems to vary between different themes, so there is no way of knowing where a specific color is (at least I haven't found one)This could be solved by exporting the settings object e.g.
What do you think? I could also send a PR if you like.
Anyways thanks for this cool lib! Happily using it with https://strudel.tidalcycles.org/
The text was updated successfully, but these errors were encountered: