Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme selection color #546

Closed
guillermoamaral opened this issue Jul 27, 2023 · 5 comments
Closed

Theme selection color #546

guillermoamaral opened this issue Jul 27, 2023 · 5 comments

Comments

@guillermoamaral
Copy link

guillermoamaral commented Jul 27, 2023

Hi,

I'm trying to use "selection" theme property to change the selection background color. However, it does not take effect (as the selectionMatch does).

https://codesandbox.io/s/damp-platform-tqn22j?file=/src/App.js

(I used a dark background on purpose, first because I want to use it in my app, and secondly because the issue is more notorious; however, you can change the configuration to use a light them, with a white background for instance, and you'll see that the selection color is not applied; what it is honored is the match selection color).

Thanks!

@jaywcjlove
Copy link
Member

https://codesandbox.io/embed/jolly-mclaren-gyp3h5?fontsize=14&hidenavigation=1&theme=dark

@guillermoamaral I'm not sure what the problem is, I tested that the colors display normally.

@guillermoamaral
Copy link
Author

@jaywcjlove Essentially you don't get the color you set.

@guillermoamaral
Copy link
Author

Screenshot_20230728_014708_Chrome
The background color of the text selected (on the left) cannot be changed, and for some backgrounds is almost undistinguishable. On the right you see the cyan set as selectionMatch.

jaywcjlove added a commit that referenced this issue Jul 28, 2023

Verified

This commit was signed with the committer’s verified signature.
weirdan Bruce Weirdan
jaywcjlove added a commit that referenced this issue Jul 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jaywcjlove
Copy link
Member

@guillermoamaral Upgrade v4.21.9

@guillermoamaral
Copy link
Author

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants